On Thu, Feb 04, 2010 at 10:42:27AM +0100, Lukasz Wojcik wrote:
> On 01.02.2010 05:46, David Gibson wrote:
> >On Fri, Jan 29, 2010 at 05:31:51PM +0100, Lukasz Wojcik wrote:
> >>This mod allows successful build of dtc using both bison/flex and
> >>yacc/lex.
> >Hrm.  This will enable dtc to build with both bison and yacc, however,
> >it will sacrifice the (much) more useful error messages that
> >%locations gives us on bison.  So I'm not very happy to do this
> >unconditionally.

> Would you be so kind, and possibly point me out where exactly the
> differences between error messages before and after applying this
> patch lies ? I did some
> testing around dtc being compiled using:

Ah, sorry, I was mistaken.  I'd forgotten that we were using our own
overridden version of yyerror() which will generate errors including
location information, even with %locations.  I withdraw my objections
to the patch.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to