On Tue, Nov 9, 2010 at 8:27 AM, Rob Herring <[email protected]> wrote: > Grant, > > With the of_match_table pointer only enabled with CONFIG_OF in struct > device_driver, all drivers will have to have #ifdefs around their > of_match_table if you want to build them for non-devicetree platforms. This > is just the tip of the iceberg as all probe related OF calls have to be > ifdef'ed. Is this the intention?
Not really, and I'm not entirely sure about the best way to handle this. I might handle the of_match_table pointer using a macro so that the #ifdefs can be dropped in each individual device driver definition, or I might ask Greg to drop the #ifdefs around of_match_table in struct device_driver, but I don't really want to increase the size of struct device_driver for non-devicetree users. Regardless, device drivers will still need #ifdefs around the CONFIG_OF specific code in the probe routine; probably by breaking the CONFIG_OF specific stuff into a helper function so that the #ifdef isn't in the middle of a function. g. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
