* H. Peter Anvin <[email protected]> wrote:
> What? What is wrong with static variables in functions? It really doesn't
> seem
> to be a good idea to make them file-scope if they don't need to be.
They are very easy to overlook and mix up with regular stack variables and i've
seen
(and introduced myself) a number of bugs due to them.
They also often are used in buggy ways (with SMP not taken into consideration),
so
overlooking them during review compounds their negative effects. Putting them
in
front of the function isnt a big deal in exchange.
There are people who never overlook them (like yourself), but my brain is wired
up
differently.
Thanks,
Ingo
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
