Hi list,

while working on fdt support for the nios2 I was reading some code for other archs I also looked at the microblaze code and I believe I found some leftovers from a copy/paste action, attached is a small patch (untested) to fix a debug print and (more important) remove a useless call to early_init_dt_check_for_initrd.

I do still have one concern, do I understand correctly that there is no way to do address-translation (the "ranges" stuff) on a flattenend tree, using the of_get_flat_dt_* functions? This would mean that this code would fail to get the correct address for a uartlite connected to a bus that has address-translation.

Greetingz
Walter
diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/prom.c
index a105301..c881393 100644
--- a/arch/microblaze/kernel/prom.c
+++ b/arch/microblaze/kernel/prom.c
@@ -61,14 +61,12 @@ static int __init early_init_dt_scan_serial(unsigned long 
node,
        char *p;
        int *addr;
 
-       pr_debug("search \"chosen\", depth: %d, uname: %s\n", depth, uname);
+       pr_debug("search \"serial\", depth: %d, uname: %s\n", depth, uname);
 
 /* find all serial nodes */
        if (strncmp(uname, "serial", 6) != 0)
                return 0;
 
-       early_init_dt_check_for_initrd(node);
-
 /* find compatible node with uartlite */
        p = of_get_flat_dt_prop(node, "compatible", &l);
        if ((strncmp(p, "xlnx,xps-uartlite", 17) != 0) &&
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to