On Mon, Jan 17, 2011 at 02:29:20PM +0800, Thomas Chou wrote: > From: Walter Goossens <[email protected]> >
For my education, why is this needed? > Signed-off-by: Walter Goossens <[email protected]> > Signed-off-by: Thomas Chou <[email protected]> > --- > drivers/input/serio/altera_ps2.c | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/serio/altera_ps2.c > b/drivers/input/serio/altera_ps2.c > index 7998560..93054a1 100644 > --- a/drivers/input/serio/altera_ps2.c > +++ b/drivers/input/serio/altera_ps2.c > @@ -19,6 +19,9 @@ > #include <linux/platform_device.h> > #include <linux/io.h> > #include <linux/slab.h> > +#ifdef CONFIG_OF > +#include <linux/of.h> > +#endif Does it have to be guarded? > > #define DRV_NAME "altera_ps2" > > @@ -173,6 +176,16 @@ static int __devexit altera_ps2_remove(struct > platform_device *pdev) > return 0; > } > > +#ifdef CONFIG_OF > +static struct of_device_id altera_ps2_match[] = { Not const? > + { > + .compatible = "altera,altera_ps2", > + }, > + {}, > +} > +MODULE_DEVICE_TABLE(of, altera_jtaguart_match); > +#endif /* CONFIG_OF */ > + > /* > * Our device driver structure > */ > @@ -182,6 +195,9 @@ static struct platform_driver altera_ps2_driver = { > .driver = { > .name = DRV_NAME, > .owner = THIS_MODULE, > +#ifdef CONFIG_OF > + .of_match_table = altera_ps2_match, > +#endif Can't we spare 4 bytes per driver and have .of_match_table always present? -- Dmitry _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
