On 02/04/2011 01:34 AM, Grant Likely wrote:
Hi Thomas, comments below, but looking pretty close.
Thanks a lot.
+config SPI_ALTERA
+ tristate "Altera SPI Controller"
+ select SPI_BITBANG
Will this compile on all architectures? Will it break allyesconfig
on anything other than nios?
Yes, it compile on other architectures. I will add 'default n' though.
There are soft-core arm, mips and coldfire running on altera fpga.
Others might use fpga as peripheral extender, too. So we shouldn't limit
it to nios2.
+static int __init altera_spi_init(void)
+{
+ return platform_driver_probe(&altera_spidrv, altera_spi_probe);
platform_driver_register() please, and put the altera_spi_probe()
routine into the driver structure.
I will change it to register as you suggested.
- Thomas
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss