On Wed, Feb 16, 2011 at 08:43:21AM +0100, Tobias Klauser wrote: > On 2011-02-16 at 05:32:01 +0100, Grant Likely <[email protected]> > wrote: > > On Wed, Feb 09, 2011 at 10:58:13AM +0100, Tobias Klauser wrote: > > > With the recent switch of the (currently still out-of-tree) Nios2 Linux > > > port to devicetree we want to be able to retreive the resources and > > > properties from dts. > > > > > > The old method to retreive resources and properties from platform data > > > is still supported. > > > > > > Signed-off-by: Tobias Klauser <[email protected]> > > > --- [...] > > > +static struct of_device_id altera_uart_match[] = { > > > + { .compatible = "altr,uart-1.0", }, > > > + {}, > > > +}; > > > +MODULE_DEVICE_TABLE(of, altera_uart_match); > > > > Need to protect the MODULE_DEVICE_TABLE with #ifdef/#endif. You don't > > want to advertise device tree support when CONFIG_OF isn't selected. > > Shall I put the #ifdef around the whole table and define it as NULL if > CONFIG_OF is not defined - like this: > > #ifdef CONFIG_OF > static struct of_device_id altera_uart_match[] = { > { .compatible = "altr,uart-1.0", }, > {}, > }; > MODULE_DEVICE_TABLE(of, altera_uart_match); > #else > #define altera_uart_match NULL > #endif /* CONFIG_OF */ > > or will it be sufficient to just #ifdef the MODULE_DEVICE_TABLE: > > static struct of_device_id altera_uart_match[] = { > { .compatible = "altr,uart-1.0", }, > {}, > }; > #ifdef CONFIG_OF > MODULE_DEVICE_TABLE(of, altera_uart_match); > #endif
Either is fine, but the first will have a smaller memory footprint when CONFIG_OF is deselected. g. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
