On Thu, Jun 23, 2011 at 10:38 AM, Rob Herring <[email protected]> wrote: > From: Rob Herring <[email protected]> > > A common use of of_get_property in driver is to just get a 32-bit integer > value, but the interface is a bit complicated in that case. Add a helper > function that just fills in the value.
Hey Rob, I already asked Thomas Abraham to write a patch that does exactly this. He's already posted his first draft to the list. His version also covers u64 and strings, so I'm going to let him respin his version and pick that one up. > Grant, > > I noticed most callers of of_get_property don't do be32_to_cpup on the > returned pointer. Most instances appear to be powerpc only drivers, but > should of_get_property return ptr be __be32? No. Not all properties contain cell values. Having of_get_property return void* is the correct behaviour. g. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
