On 10/24/2011 04:12 PM, Baruch Siach : > Hi Nicolas, > > On Mon, Oct 24, 2011 at 04:05:00PM +0200, Nicolas Ferre wrote: >> Create a new device tree source file for Atmel at91sam9g45 SoC family. >> The Evaluation Kit at91sam9m10g45ek includes it. >> This first basic support will be populated as drivers and boards will be >> converted to device tree. >> Contains serial, dma and interrupt controllers. >> >> The generic board file still takes advantage of platform data for early >> serial >> init. As we need a storage media and the NAND flash driver is not converted >> to >> DT yet, we keep old initialization for it. >> >> Signed-off-by: Nicolas Ferre <[email protected]> >> --- > > [snip] > >> +DT_MACHINE_START(at91sam9m10g45ek_dt, "Atmel AT91SAM (Device Tree)") > > Since this is a generic AT91 machine descriptor, won't "at91sam_dt" be a more > appropriate name?
For sure that makes sense. I queue this change and make it appear only in the pull request if it is the only change requested. >> + /* Maintainer: Atmel */ >> + .timer = &at91sam926x_timer, >> + .map_io = at91_map_io, >> + .init_early = ek_init_early, >> + .init_irq = at91_dt_init_irq, >> + .init_machine = at91_dt_device_init, >> + .dt_compat = at91_dt_board_compat, >> +MACHINE_END > > baruch Thanks for your review, Best regards, -- Nicolas Ferre _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
