On Fri, Oct 28, 2011 at 02:38:09PM +0200, Nicolas Ferre wrote: > On 10/28/2011 01:33 PM, Sven Schnelle : > > If CONFIG_OF is disabled, compilation fails with: > > > > drivers/tty/serial/atmel_serial.c: In function 'atmel_serial_probe': > > drivers/tty/serial/atmel_serial.c:1788: error: implicit declaration of > > function 'of_alias_get_id' > > > > Fix this by adding the proper CONFIG_OF checks. > > Yes, but I would like to avoid this and I have made a patch to address > this issue. I have sent it to the device tree guys yesterday: > "[PATCH] dt: add empty of_alias_get_id() for non-dt builds" > > Maybe we can wait a little and see if it reaches Linus' tree on time. If > it is not, I will make sure that such a fix make it to mainline.
I agree, the other dt: patch is the correct way to fix this, not this driver-only #ifdef hack. thanks, greg k-h _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
