On Wed, Nov 30, 2011 at 12:38:19PM -0700, Grant Likely wrote: > On Mon, Nov 21, 2011 at 8:37 AM, Shawn Guo <[email protected]> wrote: > > On Tue, Nov 08, 2011 at 06:19:41PM -0700, Grant Likely wrote: > >> +struct clk *of_clk_get_by_name(struct device_node *np, const char *name) > >> +{ > >> + int index = 0; > >> + > >> + if (name) > >> + index = of_property_match_string(np, "clock-input-names", > >> name); > > > > If it fails to match name, we may want to force 'index' back to 0. > > Actually, if it fails to match, the function should fail.
Hmm, that will require the clock-input-name be same as the second parameter of clk_get() - con_id, which may have been named to some string not suitable for clock-input-name. For those case, we will probably need to change the drivers to rename the con_id? Or just force the clock-input-name to be that improper con_id string? -- Regards, Shawn _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
