On Thu, Dec 01, 2011 at 01:49:20PM -0700, Stephen Warren wrote: > + /* Default platform data, for use if none is supplied */ > + defpdata.irq_active_low = false; > + defpdata.micdet_cfg = 0; > + defpdata.micdet_delay = 0;
No need to set things to zero (or just memset the structure). > + defpdata.gpio_base = -1; > + for (i = 0; i < ARRAY_SIZE(defpdata.gpio_cfg); i++) > + defpdata.gpio_cfg[i] = 0xffffffff; These should come after we've taken the copy, checking to see if there'a anything there before overwriting. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
