On 12/20/2011 12:10 PM, Dong Aisheng wrote: > From: Dong Aisheng <[email protected]> > > Checkpatch script will report some warnings for the old coding style: > WARNING: suspect code indent for conditional statements (8, 0) > for (child = of_get_next_child(parent, NULL); child != NULL; \ > [...] > +static inline int of_get_child_count(const struct device_node *np) > > Signed-off-by: Dong Aisheng <[email protected]> > Cc: Grant Likely <[email protected]> > Cc: Rob Herring <[email protected]> > --- > include/linux/of.h | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/linux/of.h b/include/linux/of.h > index f1a490c..95dee0a 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -163,22 +163,22 @@ extern struct device_node *of_find_node_by_name(struct > device_node *from, > const char *name); > #define for_each_node_by_name(dn, name) \ > for (dn = of_find_node_by_name(NULL, name); dn; \ > - dn = of_find_node_by_name(dn, name)) > + dn = of_find_node_by_name(dn, name)) > extern struct device_node *of_find_node_by_type(struct device_node *from, > const char *type); > #define for_each_node_by_type(dn, type) \ > for (dn = of_find_node_by_type(NULL, type); dn; \ > - dn = of_find_node_by_type(dn, type)) > + dn = of_find_node_by_type(dn, type)) > extern struct device_node *of_find_compatible_node(struct device_node *from, > const char *type, const char *compat); > #define for_each_compatible_node(dn, type, compatible) \ > for (dn = of_find_compatible_node(NULL, type, compatible); dn; \ > - dn = of_find_compatible_node(dn, type, compatible)) > + dn = of_find_compatible_node(dn, type, compatible)) > extern struct device_node *of_find_matching_node(struct device_node *from, > const struct of_device_id *matches); > #define for_each_matching_node(dn, matches) \ > for (dn = of_find_matching_node(NULL, matches); dn; \ > - dn = of_find_matching_node(dn, matches)) > + dn = of_find_matching_node(dn, matches)) > extern struct device_node *of_find_node_by_path(const char *path); > extern struct device_node *of_find_node_by_phandle(phandle handle); > extern struct device_node *of_get_parent(const struct device_node *node); > @@ -187,13 +187,13 @@ extern struct device_node *of_get_next_child(const > struct device_node *node, > struct device_node *prev); > #define for_each_child_of_node(parent, child) \ > for (child = of_get_next_child(parent, NULL); child != NULL; \ > - child = of_get_next_child(parent, child)) > + child = of_get_next_child(parent, child)) > > extern struct device_node *of_find_node_with_property( > struct device_node *from, const char *prop_name); > #define for_each_node_with_property(dn, prop_name) \ > for (dn = of_find_node_with_property(NULL, prop_name); dn; \ > - dn = of_find_node_with_property(dn, prop_name)) > + dn = of_find_node_with_property(dn, prop_name)) > > extern struct property *of_find_property(const struct device_node *np, > const char *name,
The old way looks fine to me and indenting like this is commonly used in the kernel. Rob _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
