> -----Original Message----- > From: Rob Herring [mailto:[email protected]] > Sent: Wednesday, December 21, 2011 2:50 AM > To: Dong Aisheng-B29396 > Cc: [email protected]; [email protected]; linux- > [email protected]; [email protected]; Guo Shawn-R65073 > Subject: Re: [PATCH 1/1] dt: reform for_each_property to > for_each_property_of_node_of_node > Importance: High > > > On 12/20/2011 11:51 AM, Dong Aisheng wrote: > > From: Dong Aisheng <[email protected]> > > > > Make this micro more easy to use(do not need to pass properties, a > > node is > > Make this macro easier to use... > Acked.
> > enough), also change to a more sensible name as for_each_child_of_node. > > > > Signed-off-by: Dong Aisheng <[email protected]> > > Cc: Grant Likely <[email protected]> > > Cc: Rob Herring <[email protected]> > > Cc: Shawn Guo <[email protected]> > > --- > > drivers/of/base.c | 2 +- > > include/linux/of.h | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/of/base.c b/drivers/of/base.c index > > 9b6588e..f6f6fe8 100644 > > --- a/drivers/of/base.c > > +++ b/drivers/of/base.c > > @@ -1159,7 +1159,7 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 > align)) > > if (!of_aliases) > > return; > > > > - for_each_property(pp, of_aliases->properties) { > > + for_each_property_of_node(of_aliases, pp) { > > const char *start = pp->name; > > const char *end = start + strlen(start); > > struct device_node *np; > > diff --git a/include/linux/of.h b/include/linux/of.h index > > 4948552..f1a490c 100644 > > --- a/include/linux/of.h > > +++ b/include/linux/of.h > > @@ -219,8 +219,8 @@ extern int of_device_is_available(const struct > > device_node *device); extern const void *of_get_property(const struct > device_node *node, > > const char *name, > > int *lenp); > > -#define for_each_property(pp, properties) \ > > - for (pp = properties; pp != NULL; pp = pp->next) > > +#define for_each_property_of_node(dn, pp) \ > > + for (pp = dn->properties; pp != NULL; pp = pp->next) > > Probably should prepend it with "of_" while you're at it. > I agree. But it seems other help microes also do not with a "of_" prefix Like for_each_child_of_node. So I just follow the old convention. Do you think I need to change this one firstly? Regards Dong Aisheng _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
