On 02/07/2012 12:53 PM, Jean-Christophe PLAGNIOL-VILLARD : > On 11:30 Tue 07 Feb , Nicolas Ferre wrote: >> On 02/06/2012 11:35 AM, Jean-Christophe PLAGNIOL-VILLARD : >>> use a local copy of board informatin and fill with DT data >>> >>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]> >>> Acked-by: Grant Likely <[email protected]> >>> Cc: Nicolas Ferre <[email protected]> >>> Cc: [email protected] >>> Cc: [email protected] >> >> [..] >> >>> +static int __devinit atmel_of_init_port(struct atmel_nand_host *host, >>> + struct device_node *np) >> >> Maybe you will need to protect this function in case of !DT builds: I >> suspect that some of the of_xxxxx() calls are not provided if !CONFIG_OF. > no-need on the of_ function are static inline it !CONFIG_OF
Sorry to come back to this but: of_get_nand_ecc_mode(np); of_get_nand_on_flash_bbt(np); for example are not available in case of non-DT compilation: so we must protect the atmel_of_init_port() against this error. Can you please rework another patch. Bye, -- Nicolas Ferre _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
