On Fri, Mar 02, 2012 at 06:32:33PM +0000, Arnd Bergmann wrote:
> On Friday 02 March 2012, Jason Cooper wrote:
> > + wdt_reg = (void __iomem *)TIMER_VIRT_BASE;
> > +
> > + ret = of_address_to_resource(np, 0, &res);
> > + if (ret) {
> > + printk(KERN_ERR "invalid address\n");
> > + return ret;
> > + }
> > +
> > + wdt_reg = ioremap(res.start, res.end - res.start);
> > +
>
> This will break non-dt uses because you overwrite the wdt_reg value.
Don't also forget that "res.end - res.start" is also not correct, and
resource_size() should be used to prevent that kind of error.
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
