On Sun, Mar 04, 2012 at 04:48:17PM +0000, Arnd Bergmann wrote:
> On Sunday 04 March 2012, Michael Walle wrote:
> > in my older patch series i flagged all converted devices with two
> > compatibility names. Eg:
> >
> > { .compatible = "marvell,orion5x-rtc", },
> > { .compatible = "marvell,kirkwood-rtc", },
> >
> > IMHO marvell,rtc is i little too general, i guess marvell won't have only
> > one
> > rtc ;)
> >
> > Other opinions?
>
> Being specific is certainly good, and it may also be a good idea to
> list the first one it's compatible with in the device tree source.
>
> So the device tree for a 88F6281 soc could list
>
> compatible = "marvell,88f6281-rtc", "marvell,kirkwood-rtc",
> "marvell,orion-rtc";
I'll go ahead and make this style of change throughout. I assume
"marvell,88f6281-rtc" would only be for SoC internal devices? eg, the spi
driver wouldn't follow that convention. I'll see if I can dig up a part
number on it.
> This would give the device driver the option which one to bind to. Anything
> that
> has an rtc compatible with the one in orion should list that one, so that the
> driver
> only has to list that one if they are truely identical, but if the driver has
> to
> get modified later to know the difference between orion and kirkwood rtcs, it
> can
> check the more specific value.
>
> Arnd
thx,
Jason.
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
