Other than Arnd's comments: On 3/13/2012 8:17 PM, Stefan Roese wrote:
> diff --git a/arch/arm/boot/dts/spear600-evb.dts > b/arch/arm/boot/dts/spear600-evb.dts > new file mode 100644 > index 0000000..f92d099 > --- /dev/null > +++ b/arch/arm/boot/dts/spear600-evb.dts > @@ -0,0 +1,23 @@ > +/* > + * Copyright 2011 Freescale Semiconductor, Inc. > + * Copyright 2011 Linaro Ltd. > + * Just for knowledge, why are above two here? Is including them suggested for all dts files? > + * Copyright 2012 Stefan Roese <[email protected]> > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > diff --git a/arch/arm/mach-spear6xx/Kconfig b/arch/arm/mach-spear6xx/Kconfig > index ff4ae5b..7777f72 100644 > --- a/arch/arm/mach-spear6xx/Kconfig > +++ b/arch/arm/mach-spear6xx/Kconfig > @@ -11,6 +11,13 @@ config BOARD_SPEAR600_EVB > help > Supports ST SPEAr600 Evaluation Board > > +config BOARD_SPEAR600_DT > + bool "SPEAr600 generic board configured via device-tree" > + select MACH_SPEAR600 > + select USE_OF > + help > + Supports ST SPEAr600 boards configured via the device-tree > + > endmenu > > config MACH_SPEAR600 > diff --git a/arch/arm/mach-spear6xx/Makefile b/arch/arm/mach-spear6xx/Makefile > index cc1a4d8..e2d79b8 100644 > --- a/arch/arm/mach-spear6xx/Makefile > +++ b/arch/arm/mach-spear6xx/Makefile > @@ -10,3 +10,4 @@ obj-$(CONFIG_MACH_SPEAR600) += spear600.o > > # spear600 boards files > obj-$(CONFIG_BOARD_SPEAR600_EVB) += spear600_evb.o > +obj-$(CONFIG_BOARD_SPEAR600_DT) += board-dt.o > diff --git a/arch/arm/mach-spear6xx/board-dt.c > b/arch/arm/mach-spear6xx/board-dt.c > new file mode 100644 > index 0000000..ee4ff33 > --- /dev/null > +++ b/arch/arm/mach-spear6xx/board-dt.c > @@ -0,0 +1,75 @@ > +/* > + * arch/arm/mach-spear6xx/board-dt.c > + * > + * Generic SPEAr600 platform support > + * > + * Copyright (C) 2009 ST Microelectronics > + * Viresh Kumar<[email protected]> ^ Thanks for this. Can add space here between r & <. > + * > + * Copyright 2012 Stefan Roese <[email protected]> > + * > + * This file is licensed under the terms of the GNU General Public > + * License version 2. This program is licensed "as is" without any > + * warranty of any kind, whether express or implied. > + */ > + > +#include <linux/of.h> > +#include <linux/of_irq.h> > +#include <linux/of_platform.h> > +#include <linux/of_address.h> keeping header files in alphabetical order makes life easy at later stages. :) > +#include <asm/hardware/vic.h> > +#include <asm/mach/arch.h> > +#include <asm/mach-types.h> > +#include <mach/generic.h> > +#include <mach/hardware.h> > + > +static struct amba_device *amba_devs[] __initdata = { > + &gpio_device[0], > + &gpio_device[1], > + &gpio_device[2], > + &uart_device[0], > + &uart_device[1], > +}; > + > +static struct platform_device *plat_devs[] __initdata = { > +}; > + > +static void __init spear600_dt_init(void) > +{ > + unsigned int i; > + > + /* call spear600 machine init function */ > + spear600_init(); > + > + /* Add Platform Devices */ > + platform_add_devices(plat_devs, ARRAY_SIZE(plat_devs)); > + > + /* Add Amba Devices */ > + for (i = 0; i < ARRAY_SIZE(amba_devs); i++) > + amba_device_register(amba_devs[i], &iomem_resource); > +} > + > +static const char *spear600_dt_board_compat[] = { > + "st,spear600-evb", > + NULL > +}; > + > +static const struct of_device_id vic_of_match[] __initconst = { > + { .compatible = "arm,pl190-vic", .data = vic_of_init, }, > + { /* Sentinel */ } > +}; > + > +static void __init spear6xx_dt_init_irq(void) > +{ > + of_irq_init(vic_of_match); > +} > + What about adding this routine in vic.c file, which can then be used by all platforms, instead of replicating this code. > +DT_MACHINE_START(SPEAR600_DT, "ST-SPEAR600-DT") It looks this is not a generic file for all boards, but for a single board? And that would be evb only? If above is true, we may name this file and internal stuff more appropriately. > + .map_io = spear6xx_map_io, > + .init_irq = spear6xx_dt_init_irq, > + .handle_irq = vic_handle_irq, > + .timer = &spear6xx_timer, > + .init_machine = spear600_dt_init, > + .restart = spear_restart, > + .dt_compat = spear600_dt_board_compat, > +MACHINE_END Thanks for the patch. :) -- viresh _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
