> On Wed, Mar 21, 2012 at 02:26:53PM +1100, David Gibson wrote: > > On Tue, Mar 20, 2012 at 08:23:46PM -0600, Stephen Warren wrote: > > > On Ubuntu, /bin/sh is dash (at least by default), and dash's echo doesn't > > > accept the -e option. This means that fdtget-runtest.sh's EXPECT file will > > > contain "-e foo" rather than just "foo", which causes a test failure. > > > > > > To work around this, run /bin/echo instead of (builtin) echo, which has > > > more chance of supporting the -e option. > > > > > > Another possible fix is to change all the #! lines to /bin/bash rather > > > than /bin/sh, and change run_tests.sh to invoke sub-scripts using $SHELL > > > instead of just "sh". However, that would require bash specifically, which > > > may not be desirable. > > > > > > Signed-off-by: Stephen Warren <swar...@wwwdotorg.org> > > > > Acked-by: David Gibson <da...@gibson.dropbear.id.au> > > > > Jon, please apply. > > Sorry Jon, you fell off the Cc list somehow. Do you need me to resend > Stephen's patch to apply?
Please. Last mail I saw on this issue was you saying "This patch isn't perfect." :-) jdl _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
