On 04/11/2012 11:24 PM, Viresh Kumar wrote:
> Signed-off-by: Viresh Kumar <[email protected]>
Just a couple of minor comments below.
> diff --git a/arch/arm/boot/dts/spear300-evb.dts
> b/arch/arm/boot/dts/spear300-evb.dts
> + pinmux@99000000 {
> + st,pinmux-mode=<2>;
spaces around = here for consistency?
> + state_default: pinmux {
> + i2c0 {
> + st,pins = "i2c0_grp";
> + st,function = "i2c0";
> + };
Do the group names need the "_grp" suffix? If that's what's in your TRM,
it's fine by me, but I'd guess that isn't the case, and if so I'd say
either drop the _grp suffix here, or enhance the binding documentation
to mention the need to add this suffix when writing the .dts file.
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
