On Mon, Apr 23, 2012 at 07:01:58PM +0200, John Crispin wrote: > pinmux_map_to_setting() uses setting->data.mux.func/group to store the return > code of pinmux_func_name_to_selector/pinctrl_get_group_selector(). However, > struct pinctrl_setting_mux defines these elements as unsigned, resulting in > all > error codes getting lost. The conditionals following the assignments will > always > evaluate to false thus breaking the error paths. > > This bug can be triggered by loading a pinmux group map from the devicetree > with an invalid function/group string. > > Signed-off-by: John Crispin <[email protected]> > Cc: Stephen Warren <[email protected]> > Cc: Dong Aisheng <[email protected]> > --- > drivers/pinctrl/pinmux.c | 15 ++++++++------- > 1 files changed, 8 insertions(+), 7 deletions(-) > Nice fix.
Acked-by: Dong Aisheng <[email protected]> Regards Dong Aisheng _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
