On Fri, Apr 27, 2012 at 04:54:46PM +0800, Dong Aisheng wrote: > On Fri, Apr 27, 2012 at 04:31:42PM +0800, Sascha Hauer wrote: > > On Fri, Apr 27, 2012 at 04:29:31PM +0800, Dong Aisheng wrote: > > > mach-imx27ipcam.c mach-mx31ads.c mach-mx51_babbage.o > > > mach-pca100.c > > > mach-imx27lite.c mach-mx31ads.o mach-mx51_efikamx.c > > > mach-pcm037.c > > > > > > Some of them i'm not familiar and i don't know whether they may use > > > pinctrl > > > so i just patched the affected ones. > > > > > > One lazy method may be just patch all board files without pinctrl support > > > and it will not cause any error. > > > > > > What's your suggestion? > > > > > > > pinctrl. Let's add the provide_dummies call to the SoCs instead which > > > > do not have pinctrl yet. > > > > > > > You meant add provide_dummies call in imx*_soc_init call? > > > We could do it but there might be a case that some boards are converted > > > to use pinctrl while others still not but they're based on the same soc. > > > For examples, 4 mx53 boards and we may not be able to convert them all at > > > the same time. > > > > My point is that none of the mx5 boards have pinctrl since there is no > > SoC driver for it. > > For DT based boards pinctrl should be mandatory once the SoC has pinctrl > > support. All non DT boards probably won't get pinctrl anyway. > > > Ok, so i would be fine for me to change it in imx*_soc_init. > BTW, there're: > imx1_soc_init() > imx25_soc_init() > imx27_soc_init() > imx31_soc_init() > imx35_soc_init() > imx50_soc_init() > imx51_soc_init() > imx53_soc_init() > > I'm not sure about mx1, mx27, mx31 > Do you think if i could add them all?
Of course. Or do you see a pinctrl driver for any i.MX except i.MX6? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
