Hello, On Mon, Apr 23, 2012 at 10:56:21AM +0200, Uwe Kleine-König wrote: > Drivers should never need to modify the data of a device id. So it can > be const which in turn allows more consts in the driver. > > Signed-off-by: Uwe Kleine-König <[email protected]> > --- > this might introduce warnings in drivers that access the data member > without using const, so this is definitly merge window material if it is > considered at all. > > include/linux/mod_devicetable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h > index 501da4c..183f411 100644 > --- a/include/linux/mod_devicetable.h > +++ b/include/linux/mod_devicetable.h > @@ -222,7 +222,7 @@ struct of_device_id > char type[32]; > char compatible[128]; > #ifdef __KERNEL__ > - void *data; > + const void *data; > #else > kernel_ulong_t data; > #endif any thoughts on this one? I got no feed back and it doesn't appear in next-20120518.
Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
