On Fri, May 25, 2012 at 11:37:26AM +0300, Alexander Shishkin wrote: > Richard Zhao <[email protected]> writes: > > > This patch supports only the host-mode functionality so far. > > > > Signed-off-by: Richard Zhao <[email protected]> > > Signed-off-by: Marek Vasut <[email protected]> > > Cc: Peter Chen <[email protected]> > > Cc: Alexander Shishkin <[email protected]> > > Cc: Felipe Balbi <[email protected]> > > Cc: Greg Kroah-Hartman <[email protected]> > > --- > > .../devicetree/bindings/usb/ci13xxx-imx.txt | 20 ++ > > drivers/usb/chipidea/Makefile | 3 + > > drivers/usb/chipidea/ci13xxx_imx.c | 189 > > ++++++++++++++++++++ > > One comment: I was going to suggest dropping "13xxx" suffix from > everywhere in the driver, maybe module names too, since it doesn't > really add any value and people often mistype it, so maybe for the new > code it makes sense to avoid it? ci-imx looks better than ci13xxx-imx > anyway and same goes for ci_imx_probe() vs ci13xxx_imx_probe(). > Does this make sense to you? I'm not clear with the history. Does Chipidea only have one IP?
Thanks Richard > > Regards, > -- > Alex > _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
