On Fri, 2012-06-15 at 22:00 -0600, Grant Likely wrote: > On Sat, 16 Jun 2012 08:57:50 +1000, Benjamin Herrenschmidt > <[email protected]> wrote: > > On Fri, 2012-06-15 at 11:50 -0600, Grant Likely wrote: > > > The pattern (np ? np->full_name : "<none>") is rather common in the > > > kernel, but can also make for quite long lines. This patch adds a new > > > inline function, of_node_full_name() so that the test for a valid node > > > pointer doesn't need to be open coded at all call sites. > > > > s/of_node_full_name/of_node_path ? > > It would be nicer to have the shorter name, but the data member is > already named full_name, so I'd rather use the same for the function > name (unless you argue strongly against, it's not something I'm going > to fight about).
Nah, it's just that full_name was never a very good choice to begin with ... Do as you wish. Renaming the data member might be a bit annoying I can immagine :-) Cheers, Ben. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
