On 06/04/2012 06:15 AM, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/of/base.c:176:41: warning: Using plain integer as NULL pointer
> drivers/of/base.c:178:37: warning: Using plain integer as NULL pointer
> drivers/of/base.c:500:49: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat <[email protected]>
Sorry for the delay.
> ---
> drivers/of/base.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index d9bfd49..2031aa1 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -173,9 +173,9 @@ struct property *of_find_property(const struct
> device_node *np,
> return NULL;
>
> read_lock(&devtree_lock);
> - for (pp = np->properties; pp != 0; pp = pp->next) {
> + for (pp = np->properties; pp != NULL; pp = pp->next) {
How about just "pp"
> if (of_prop_cmp(pp->name, name) == 0) {
> - if (lenp != 0)
> + if (lenp != NULL)
and "if (lenp)"
> *lenp = pp->length;
> break;
> }
> @@ -497,7 +497,7 @@ struct device_node *of_find_node_with_property(struct
> device_node *from,
> read_lock(&devtree_lock);
> np = from ? from->allnext : allnodes;
> for (; np; np = np->allnext) {
> - for (pp = np->properties; pp != 0; pp = pp->next) {
> + for (pp = np->properties; pp != NULL; pp = pp->next) {
ditto
Rob
> if (of_prop_cmp(pp->name, prop_name) == 0) {
> of_node_get(np);
> goto out;
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
