On 28/07/12 01:23, Linus Walleij wrote: > On Tue, Jul 24, 2012 at 8:50 AM, John Crispin <[email protected]> wrote: > >> Implement support for pinctrl on lantiq/falcon socs. The FALCON has 5 banks >> of up to 32 pins. >> >> Signed-off-by: John Crispin <[email protected]> >> Signed-off-by: Thomas Langer <[email protected]> >> Cc: Linus Walleij <[email protected]> >> Cc: [email protected] >> Cc: [email protected] > No big issues and looking really sweet so: > Acked-by: Linus Walleij <[email protected]> > >> --- a/arch/mips/lantiq/Kconfig >> +++ b/arch/mips/lantiq/Kconfig >> @@ -20,6 +20,7 @@ config SOC_XWAY >> >> config SOC_FALCON >> bool "FALCON" >> + select PINCTRL_FALCON > I think you need to add "select PINCTRL" above "select PINCTRL_FALCON" > for this to work. > > Atleast I had to do that in the past to get things working.
Hi Linus, config LANTIQ selects PINCTRL globally for all Lantiq SoC so an explicit select can be avoided here Thanks for the review, John _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
