Hi Thomas, On Thu, Aug 16 2012, Thomas Abraham wrote: > Add device tree based discovery support for Samsung's sdhci controller > > Cc: Ben Dooks <[email protected]> > Cc: Kukjin Kim <[email protected]> > Cc: Chris Ball <[email protected]> > Signed-off-by: Thomas Abraham <[email protected]> > --- > drivers/mmc/host/sdhci-s3c.c | 146 > ++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 140 insertions(+), 6 deletions(-)
I know your initial version was submitted before we adopted a set of standard MMC DT bindings, but now that those bindings exist this code should be using them -- there should be a new file: Documentation/devicetree/bindings/mmc/sdhci-s3c.txt describing differences between the mmc.txt bindings and this driver's. Also, you didn't include a patch changelog, so I can't tell whether this contains changes against your v3 of this patch; please do that. Thanks! - Chris. -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
