On 00:42 Sun 19 Aug , Linus Walleij wrote: > On Thu, Aug 16, 2012 at 2:40 PM, Jean-Christophe PLAGNIOL-VILLARD > <[email protected]> wrote: > > On 14:16 Thu 16 Aug , Linus Walleij wrote: > >> +/* For the Device Tree, add in the UART callbacks as AUXDATA */ > >> +static struct of_dev_auxdata ap_auxdata_lookup[] __initdata = { > >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_RTC_BASE, > >> + "rtc", NULL), > >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART0_BASE, > >> + "uart0", &integrator_uart_data), > >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART1_BASE, > >> + "uart1", &integrator_uart_data), > >> + OF_DEV_AUXDATA("arm,primecell", KMI0_BASE, > >> + "kmi0", NULL), > >> + OF_DEV_AUXDATA("arm,primecell", KMI1_BASE, > >> + "kmi1", NULL), > >> + { /* sentinel */ }, > > > why that? > > Based on similar code by Grant in arch/arm/mach-versatile/core.c > also ending with a {}. Also at other places ... I though this terminated > the list iteration, is it not needed anymore? no I mean why > >> + OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_RTC_BASE, > >> + "rtc", NULL), > >> + OF_DEV_AUXDATA("arm,primecell", KMI0_BASE, > >> + "kmi0", NULL), > >> + OF_DEV_AUXDATA("arm,primecell", KMI1_BASE, > >> + "kmi1", NULL),
no platform data why do you use the AUXDATA? as the OF_DEV_AUXDATA is deprecated now Bset Regards, J. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
