Hi Thomas, On Wed, Aug 22 2012, Thomas Abraham wrote: >> This matches Mitch's last suggestion exactly -- I think we're all agreed >> on these properties now. The only remaining question is how to handle >> the pinctrl for CD in Thomas's case. > > Hi Chris, > > For sdhci-s3c driver, the 'broken-cd' and 'cd-gpios' bindings are > sufficient. But, are drivers free to use implementation specific > behavior when using these bindings. Or do we strictly adhere to the > table which Shawn has listed. For sdhci-s3c driver, I would like to > deviate from the "implication" column listed above.
I'd rather you use the implications described above for the names described above; there's not much point in defining named behaviors across the subsystem if they're actually different in each driver. But I think you can still use driver-internal properties that change the interpretation of those names in a documented way. If the meaning of cd-gpios is modified when coupled with your "samsung,sdhci-cd-external", that's okay with me. That should cover all the cases you need until you migrate to using pinctrl, right? So, you could immediately support: none -> currently "samsung,sdhci-cd-internal" broken-cd -> currently "samsung,sdhci-cd-none" cd-gpios -> currently "samsung,sdhci-cd-gpios" non-removable -> currently "samsung,sdhci-cd-permanent" cd-gpios + samsung,sdhci-cd-external -> currently "samsung,sdhci-cd-external" How does that sound? Thanks, - Chris. -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
