On Mon, Oct 8, 2012 at 10:39 AM, Tomasz Figa <[email protected]> wrote:
> Currently SoC-specific properties such as list of pin banks, register > offsets and bitfield sizes are being taken from static data structures > residing in pinctrl-exynos.c. > > This patch modifies the pinctrl-samsung driver to parse all SoC-specific > data from device tree, which will allow to remove the static data > structures and facilitate adding of further SoC variants to the > pinctrl-samsung driver. So why? Two approaches: - Put as much info as possible into the device tree - Put as much info as possible into the driver The first approach is currently only used by pinctrl-single.c. That driver is designed for the case where all info about the hardware arrives in some description language that can be translated into a simple DT description. If you want to use that approach, you should use that driver. If that driver does not work for you, then it's not fulfilling it's purpose as a one-stop shop for simple pin controllers entirely contained within the device tree, and should be renamed or redesigned. If you will end up with a hybrid approach with some stuff in the device tree and some stuff in the code, it's better to keep the old driver. Yours, Linus Walleij _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
