On Fri, Nov 09, 2012 at 02:44:46PM +0000, Will Deacon wrote: > On Fri, Nov 09, 2012 at 02:34:10PM +0000, Lorenzo Pieralisi wrote: > > This patch applies some basic changes to the smp_setup_processor_id() > > ARM implementation to make the code that builds cpu_logical_map more > > uniform across the kernel. > > > > The function now prints the full extent of the boot CPU MPIDR[23:0] and > > initializes the cpu_logical_map for CPUs up to nr_cpu_ids. > > > > Signed-off-by: Lorenzo Pieralisi <[email protected]> > > --- > > arch/arm/kernel/setup.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c > > index da1d1aa..ede7c84 100644 > > --- a/arch/arm/kernel/setup.c > > +++ b/arch/arm/kernel/setup.c > > @@ -426,13 +426,14 @@ int __cpu_logical_map[NR_CPUS]; > > void __init smp_setup_processor_id(void) > > { > > int i; > > - u32 cpu = is_smp() ? read_cpuid_mpidr() & 0xff : 0; > > + u32 mpidr = read_cpuid_mpidr() & 0xffffff; > > We need that is_smp() check, otherwise we'll go and do a funky CP15 > operation on CPU's that might not be too happy about it.
You are right, sorry my apologies. I will have to check it even when parsing the DT then. Lorenzo _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
