Dear Andrew Lunn,

On Thu, 15 Nov 2012 22:28:25 +0100, Andrew Lunn wrote:

> +             core_clk: core-clocks@d0214 {
> +                     compatible = "marvell,dove-core-clocks";
> +                     reg = <0xd0214 0x4>;
> +                     #clock-cells = <1>;
> +             };
> +
> +             clk_gate: clock-gating-control@d0038 {
> +                     compatible = "marvell,dove-clock-gating";
> +                     reg = <0xd0038 0x4>;
> +                     clocks = <&core_clk 0>;
> +                     #clock-cells = <1>;
> +             };

I'm nitpicking maybe, but names lack a bit of coherency here:

        core_clk vs. clk_gate
        marvell,dove-core-clocks vs. marvell,dove-clock-gating

Maybe:

        core_clk / gate_clk
        marvell,dove-core-clocks / marvell,dove-gating-clocks

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to