On 11/20/2012 01:37 AM, Andrew Lunn wrote: > Hi Jason > > These are good comments from Stephan that i want to address. However, > i also don't want to delay the pull-requests direction arm-soc, the > merge window is getting close. Both Linus and Anton have Acked the > current version, so please go with what you have and i will produce a > patch over the top. If its available before Arnd pulls, you can squash > it, otherwise send it upstream as a standalone patch.
I'm not sure I agree here; the comments I made re: the delays and pulse-vs-level may affect the definition of the DT binding, and that's something that should be correct from the start. The implementation of gpio_poweroff_do_poweroff() really doesn't seem to make sense; related to the above. Also, probe deferral doesn't work, which will likely make this code completely ineffective. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
