On 20/11/12 16:45, Grant Likely wrote: > On Fri, 16 Nov 2012 13:21:08 +0000, Srinivas KANDAGATLA > <[email protected]> wrote: >> From: Srinivas Kandagatla <[email protected]> >> >> This patch series introduces of_simple_module_id_table macro and as an >> example >> uses this macro in 3 files. >> >> Most of the device tree supported drivers have of_device_id table setup with >> single compatible entry, this use-case is very simple and common. >> >> #ifdef CONFIG_OF >> static struct of_device_id xxx_of_match[] = { >> { .compatible = "yyy,zzz" }, >> { }, >> }; >> MODULE_DEVICE_TABLE(of, xxx_of_match); >> #endif >> >> This patch adds a macro for this simple type of device table. >> Other subsystems like pm, platform, have similar macros in kernel for >> simplest cases. >> Now the user can just replace the above code with >> >> of_simple_module_id_table(xxx_of_match, "yyy,zzz"); >> >> There are more than 200+ hits for this type of pattern in the current kernel. > While I like the reduction in lines of source code, I'm not so fond of > the form. There is no easy way to extend the syntax for multiple > entries and it doesn't cover the frequently present .data field. Can you > think of a way to do this that can take a variable number of table > entries? I think adding data field is straight forward I will send a v2 of this macro. However adding variable number of table entries kills the very purpose of this simple macro in the first-place.
> > g. > > _______________________________________________ > devicetree-discuss mailing list > [email protected] > https://lists.ozlabs.org/listinfo/devicetree-discuss > _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
