On 01/21/2013 07:17 PM, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> Just some minor nitpicks below.
OK I will take them into account for the V2.
Thanks
>
> On Mon, 21 Jan 2013 18:53:57 +0100, Gregory CLEMENT wrote:
>
>> + if (hw < ARMADA_370_XP_MAX_PER_CPU_IRQS) {
>> +
>
> Unneeded empty line.
>
>> + irq_set_percpu_devid(virq);
>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>> + handle_percpu_devid_irq);
>> +
>> + } else {
>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>> + handle_level_irq);
>> + }
>
> Braces useless since there is only one statement in the else.
>
>> + set_irq_flags(virq, IRQF_VALID | IRQF_PROBE);
>
> Incorrect indentation for this line.
>
> Thomas
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
