On Monday 21 January 2013, Gregory CLEMENT wrote:
> I don't see a strong reason to not enable it if we don't use it. My concern
> was that I don't need it so I didn't want to include it and generating extra
> code for nothing. Then just after having sent this patch set, I received your
> patch set about build regression in 3.8 and especially the part about
> CONFIG_MULTIPLATFORM made me realized that it could be a problem.
Ok.
> > Maybe it can be written as
> >
> > config LOCAL_TIMERS
> > bool "Use local timer interrupts"
> > depends on SMP
> > default y
> >
> > config HAVE_ARM_TWD
> > depends on LOCAL_TIMERS
> > default ARCH_MULTIPLATFORM || (!ARCH_MSM_SCORPIONMP && !EXYNOS4_MCT)
>
> So in this case why not written something like this:
> default ARCH_MULTIPLATFORM || (!ARCH_MSM_SCORPIONMP && !EXYNOS4_MCT
> && !ARMADA_370_XP_TIMER)
That does not change anything, because ARMADA_370_XP_TIMER is only ever enabled
when ARCH_MULTIPLATFORM is enabled as well.
> > default y
> I am not a kconfig expert, but won't this line set HAVE_ARM_TWD to 'y'
> whatever
> the result of the previous line?
Yes, that was a mistake on my side.
Arnd
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
