Hello Prabhakar, On 24.01.2013 10:12, Prabhakar Lad wrote: > From: Lad, Prabhakar <[email protected]> > > add OF support for the tvp514x driver. > > Signed-off-by: Lad, Prabhakar <[email protected]> > Cc: Hans Verkuil <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Mauro Carvalho Chehab <[email protected]> > Cc: Guennadi Liakhovetski <[email protected]> > --- > This patch is on top of following patches: > 1: https://patchwork.kernel.org/patch/1930941/ > 2: http://patchwork.linuxtv.org/patch/16193/ > 3: https://patchwork.kernel.org/patch/1944901/ > > .../devicetree/bindings/media/i2c/tvp514x.txt | 30 ++++++++++ > drivers/media/i2c/tvp514x.c | 60 > ++++++++++++++++++-- > 2 files changed, 85 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/i2c/tvp514x.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/tvp514x.txt > b/Documentation/devicetree/bindings/media/i2c/tvp514x.txt > new file mode 100644 > index 0000000..3cce323 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/tvp514x.txt > @@ -0,0 +1,30 @@
[...] > diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c > index a4f0a70..0e2b15c 100644 > --- a/drivers/media/i2c/tvp514x.c > +++ b/drivers/media/i2c/tvp514x.c > @@ -12,6 +12,7 @@ > * Hardik Shah <[email protected]> > * Manjunath Hadli <[email protected]> > * Karicheri Muralidharan <[email protected]> > + * Prabhakar Lad <[email protected]> > * > * This package is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License version 2 as > @@ -930,6 +931,50 @@ static struct tvp514x_decoder tvp514x_dev = { > > }; > > +#if defined(CONFIG_OF) > +static const struct of_device_id tvp514x_of_match[] = { > + {.compatible = "ti,tvp514x-decoder", }, > + {}, > +} Missing semicolon here. Without, gcc throws here an error when compiling this driver as a module. > +MODULE_DEVICE_TABLE(of, tvp514x_of_match); > + [...] bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
