On Wed, Feb 06, 2013 at 07:37:37PM +0000, Jonathan Cameron wrote:
> On 02/06/2013 06:29 PM, Guenter Roeck wrote:
> > Provide bindings and parse OF data during initialization.
> >
> > Signed-off-by: Guenter Roeck <[email protected]>
> looks good to me. Couple of little queries inline.
>
[ ... ]
> > +
> > +Example for a configuration with trigger:
> > +
> > + adc@35 {
> > + compatible = "maxim,max1139";
> > + reg = <0x35>;
> > +
> > + adc: iio-device {
> > + #io-channel-cells = <1>;
> > + };
> > + trigger: iio-trigger {
> > + #io-channel-cells = <1>;
> Why would the trigger have channel-cells?
> So far we don't have any device tree stuff for the triggers.
I thought about keeping the example and adding a note that trigger support is
not currently implemented, but a better idea is to replace it with a second iio
device. I'll do that unless someone objects.
adc@35 {
compatible = "some-vendor,some-adc";
reg = <0x35>;
adc1: iio-device@0 {
#io-channel-cells = <1>;
/* other properties */
};
adc2: iio-device@1 {
#io-channel-cells = <1>;
/* other properties */
};
};
> > +
> > +==Example==
> > +
> > + adc: max1139@35 {
> > + compatible = "maxim,max1139";
> > + reg = <0x35>;
> > + #io-channel-cells = <1>;
> > + };
> > +
> > + ...
> > +
> > + iio_hwmon {
> > + compatible = "iio-hwmon";
> > + io-channels = <&adc 0>, <&adc 1>, <&adc 2>,
> > + <&adc 3>, <&adc 4>, <&adc 5>,
> > + <&adc 6>, <&adc 7>, <&adc 8>,
> > + <&adc 9>, <&adc 10>, <&adc 11>;
> > + io-channel-names = "vcc", "vdd", "vref", "1.2V";
> This example still seems a little odd. Why give one where there are
> more channels than names?
I replaced the example with
iio_hwmon {
compatible = "iio-hwmon";
io-channels = <&adc 0>, <&adc 1>, <&adc 2>,
<&adc 3>, <&adc 4>, <&adc 5>,
<&adc 6>, <&adc 7>, <&adc 8>,
<&adc 9>;
};
some_consumer {
compatible = "some-consumer";
io-channels = <&adc 10>, <&adc 11>;
io-channel-names = "adc1", "adc2";
};
Guenter
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
