On Thu, Feb 14, 2013 at 09:33:00PM +0100, Sylwester Nawrocki wrote: > My apologies for the late review. It's already sixth version of this patch > series... But I noticed it just now when applying it for Exynos4. The GPIO > part of the bindings is now incompatible with Exynos4 and the bindings will > need to be changed. Leaving the compatibility code in the I2S driver, when > we could have it done well right from the beginning. If I'm not mistaken > a file similar to arch/arm/boot/dts/exynos4x12-pinctrl.dtsi with at least > entries for the I2S devices is needed and an addition of related pinctrl > nodes in exynos5250.dtsi. But I guess this is not something that could be > fixed in the -rc period ?
Yes, and incremental fix would be fine.
signature.asc
Description: Digital signature
_______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
