(2013/03/04 17:05), Grant Likely wrote: > On Thu, 14 Feb 2013 11:56:57 +0900, Nobuhiro > Iwamatsu<[email protected]> wrote: >> (2013/02/14 10:24), Kuninori Morimoto wrote: >>>> +#ifdef CONFIG_OF >>>> + if (np&& of_device_is_available(np)) { >>>> + pd = sh_eth_parse_dt(&pdev->dev, ndev); >>>> + if (pdev->dev.platform_data) { >>>> + struct sh_eth_plat_data *tmp = >>>> + pdev->dev.platform_data; >>>> + pd->set_mdio_gate = tmp->set_mdio_gate; >>>> + pd->needs_init = tmp->needs_init; >>>> + } >>>> + } else >>>> +#endif >>> >>> sh_eth_parse_dt() was defined for both CONFIG_OF and !CONFIG_OF. >>> But it is called only from CONFIG_OF ? >>> >> >> Because of_device_is_available needs CONFIG_OF. >> I already send a patch which add empty function of of_device_is_available. >> If this was apply, this ifdef becomes without need. > > Actually, there shouldn't be any reason for a device driver to call > of_device_is_available() on its own node at all. If the device is not > available, then a platform_device won't be created. "if (np)" here is > sufficient. >
Yes, you are right. I re-writed code without of_device_is_available(). I will send new patch soon. Best regards, Nobuhiro _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
