On Sun, Apr 07, 2013 at 09:49:03PM -0500, Timur Tabi wrote: > Markus Pargmann wrote: > >This patch copies some parts from imx-ssi to support AC97 on > >imx27-pca100 and imx27-pcm043. It is activated with a new fsl,imx-ac97 > >bool property. It was tested on imx27-pca100. > > I'm not crazy about this patch -- it seems a bit hackish. There are > too many "if (imx_ac97)" clauses. Large pieces of code that don't > appear to be related to AC97 are indented in an if-clause. I > especially don't like the "If we use AC97, the registers are already > setup correctly". >
I will try to seperate it a little bit cleaner by using different dai ops for ac97 for the two big ifs and perhaps use a seperated register setup function so it can be used from ssi startup and ac97_setup. Regards, Markus > -- > Timur Tabi > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
