Hi Lukasz, On 23 April 2013 11:47, Lukasz Majewski <[email protected]> wrote: > Hi Sachin, > >> On 19 April 2013 22:08, Lukasz Majewski <[email protected]> >> wrote: >> > This patch modifies exynos_thermal.c file to use >> > clk_disable_unprepare() and clk_prepare_enable() instead of >> > clk_{enable|disable}. >> > >> > Signed-off-by: Lukasz Majewski <[email protected]> >> > Signed-off-by: Kyungmin Park <[email protected]> >> > --- >> >> I have already submitted a similar patch for this: >> http://permalink.gmane.org/gmane.linux.power-management.general/33310 >> >> > > Thanks for pointing to the correct patch. > > However, I've got a question: > > The patch only changes clock names at exynos_tmu_{probe|remove}. > > Correct me if I'm wrong, but shouldn't we also change clock_enable to > clk_prepare_enable at exynos_tmu_read()? (Are we guaranteed, that we > will NOT sleep there?)
Since clk_prepare does not do anything, i thought it was sufficient to have it once in probe and then unprepare in remove. Do you see a real problem in this implementation. If so I can update it to use clk_prepare_enable at other places as well. -- With warm regards, Sachin _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
