On Tue, Apr 30, 2013 at 07:49:16AM +0100, Srinivas KANDAGATLA wrote: > On 29/04/13 10:08, David Gibson wrote: > > On Fri, Apr 19, 2013 at 09:36:36AM +0100, Srinivas KANDAGATLA wrote: > >> From: Srinivas Kandagatla <[email protected]> [snip] > > > >> + delta = sizeof(struct fdt_node_header) + > >> + ALIGN(newlen + 1) + FDT_TAGSIZE; > > struct fdt_node_header already includes the FDT_BEGIN_NODE tag, so > > you've allocated space for the tag twice. > Here am allocating space for FDT_BEGIN_NODE + node name in off_struct + > FDT_END_NODE. > So am not allocating space for the tag twice. > Am I missing something?
Oh, yes, sorry. Maybe put /* FDT_END_NODE */ next to the extra
FDT_TAGSIZE to stop someone else missing this the way I did.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: Digital signature
_______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
