On Wed, May 8, 2013 at 4:11 PM, Srinivas KANDAGATLA
<[email protected]> wrote:

> From: Srinivas Kandagatla <[email protected]>
>
> The STiH416 is advanced HD AVC processor with 3D graphics acceleration
> and 1.2-GHz ARM Cortex-A9 SMP CPU.
>
> Signed-off-by: Srinivas Kandagatla <[email protected]>
> CC: Stephen Gallimore <[email protected]>
> CC: Stuart Menefy <[email protected]>

(...)

This stuff is looking really good.

> +++ b/arch/arm/boot/dts/stih416.dtsi
> @@ -0,0 +1,103 @@
> +/*
> + * Copyright (C) 2012 STMicroelectronics Limited.
> + * Author: Srinivas Kandagatla <[email protected]>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * publishhed by the Free Software Foundation.
> + */
> +#include "stih41x.dtsi"
> +#include "stih416-clock.dtsi"
> +#include "stih416-pinctrl.dtsi"

Nice layering here!

> diff --git a/arch/arm/boot/dts/stih416.h b/arch/arm/boot/dts/stih416.h
> new file mode 100644
> index 0000000..2e27792
> --- /dev/null
> +++ b/arch/arm/boot/dts/stih416.h

I've seen that people start to put these into:
include/dt-bindings/

With one include per driver subsystem. I suggest you follow
this pattern.

Yours,
Linus Walleij
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to