Hi Laurent On Fri, 10 May 2013, Laurent Pinchart wrote:
> Add DT bindings for the gpio-rcar driver and read the device > configuration from the DT node at probe time if available. > > Cc: [email protected] > Signed-off-by: Laurent Pinchart <[email protected]> > --- > .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 48 +++++++++++++++++ > drivers/gpio/gpio-rcar.c | 63 > ++++++++++++++++++---- > 2 files changed, 101 insertions(+), 10 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt Testing this patch reveals, that (at least) one thing is missing here: diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index a499ea6..e233778 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -342,6 +342,7 @@ static int gpio_rcar_probe(struct platform_device *pdev) gpio_chip->owner = THIS_MODULE; gpio_chip->base = p->config.gpio_base; gpio_chip->ngpio = p->config.number_of_pins; + gpio_chip->dev = &pdev->dev; irq_chip = &p->irq_chip; irq_chip->name = name; Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
