From: Mugunthan V N <[email protected]> Date: Thu, 23 May 2013 18:00:23 +0530
> From: Hebbar Gururaja <[email protected]> > > Amend cpsw controller to optionally take a pin control handle and set > the state of the pins to: > > - "default" on boot, resume > - "sleep" on suspend() > > This should make it possible to optimize energy usage for the pins > for the suspend/resume cycle. > > If any of the above pin states are missing in dt, a warning message > about the missing state is displayed. > If certain pin-states are not available, to remove this warning message > pass respective state name with null phandler. > > Signed-off-by: Hebbar Gururaja <[email protected]> > Signed-off-by: Mugunthan V N <[email protected]> This still needs some work: > + /* > + * Since we continue even when pinctrl node is not found, > + * Invalidate pins as not available. This is to make sure that > + * IS_ERR(pins_xxx) results in failure when used. > + */ The second, third, fourth, and fifth lines are not tabbed correctly. They should all be two TABs and a SPACE. Secondly, comments in the networking are to be formatted: /* Like * this. */ _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
