On 17:41 Tue 28 May , Arnd Bergmann wrote: > On Tuesday 28 May 2013, Jean-Christophe PLAGNIOL-VILLARD wrote: > > Today in the current of implementation we populate all the > > ressources > > at of_platform_populate time. But this leed to a chicken-egg dilemat > > some the irq present in DT are from platform_device too. And you can > > not resolve them as of_platform_populate. So delay the populate of > > irq > > at platform_drv_probe. > > I like it a lot, thanks for doing this! > > Obviously this needs to be tested well on all architectures, but I think > it's the right solution for the problem. I've tested it today on a ARM at91sam9n12ek using a gpio as irq connected to a ks8851-ml > I was originally thinking we'd > just allocated the resources dynamically using devm_kmalloc in > platform_drv_probe, but your solution to preallocate them at boot > time seems nicer.
yes I should have put a comment in the patch 3/3 as the device tree is a fixed data, preallocate them at boot t time save the kalloc kree everytime you probe the device and the irq_domain is not yet present > > I believe we still need the same patch for the amba bus, and possibly > a couple more, but platform_bus covers most of the interesting cases. yes exactly Best Regards, J. > > Arnd _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
