On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote:
> On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
> <alexey.brod...@synopsys.com> wrote:
> > Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
> > instantiated in some legacy ARC (Synopsys) FPGA Boards such as
> > ARCAngel4/ML50x.
>
> Much better. But still few comments below.
Sensible comments save for this truly trivial one
> > +++ b/drivers/net/ethernet/arc/arc_emac.h
[]
> > + if (unlikely((info & OWN_MASK) == FOR_EMAC)) {
> > + /* BD is still owned by EMAC */
> > + continue;
> > + }
>
> Redundant braces.
Maybe not. Braces can be a visual aid when there is
a comment in the test.
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
