On Sun, Jul 07, 2013 at 02:31:41PM +0400, Alexander Shiyan wrote: > > On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote: > > > > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e > > > > "ARM: dts: Add device tree support for phycard pca100". > > > > > > > > Remove wrong I2C RTC node. > > > > > > > > Signed-off-by: Markus Pargmann <m...@pengutronix.de> > > > > --- > > > > > > > > Thanks, Alexander, you are right. I2C2 has no RTC. > > > ... > > > > > > There are a couple of comments on this file. > > > > > > I think that the OWIRE should be moved to the RDK. > > > > I moved OWIRE and i2c1 to RDK. Both are not used on the SOM. > > > > > ioexpander must contain "gpio-controller" at least, and for use it > > > further, > > > it is necessary to define the label for this node. > > > > I checked all I2C devices in the board schematics. There is actually no > > ioexpander. I don't know why it was added. I will send some I2C patches > > later. > > Perhaps the chip is mounted on the camera module. > A similar IC is exist on PCM-970 camera addon device. > If so, the device should also be moved to RDK.
Yes that's possible. But in that case I think the ioexpander should be removed from both dts files because the Phytec phyCARD-S RDK does not include a camera module. Regards, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
